This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixing UX issue of inactive panel getting too dim to read text for dark ... #10495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk themes. Bug: #9785 [UX] Inactive panel gets dimmed in split view in release v1.0
|
Looks good to me! @larz0 do you think the headers need any tweaks to make it more obvious which one is active now?
I think the active line highlight + blinking cursor make it pretty clear already... but I figure it's worth getting a second opinion :-) |
|
@peterflynn looks good to me too 👍 like you said, it's pretty clear already. Thanks @prksingh. |
|
All good to merge then! |
peterflynn
added a commit
that referenced
this pull request
Feb 5, 2015
Don't dim inactive panels' contents
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...themes.
Bug: #9785 [UX] Inactive panel gets dimmed in split view in release v1.0